mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Addons cannot be added for homepage shelf collections using the front end links #6235

Closed ioanarusiczki closed 5 years ago

ioanarusiczki commented 5 years ago

Followup for https://github.com/mozilla/addons/issues/5910

STR:

  1. Load AMO dev or AMO stage and with an admin account add themes using https://addons-dev.allizom.org/en-US/firefox/collections/mozilla/featured-personas/
  2. Go to AMO homepage and observe the Features Themes shelf

Expected result: The added themes are available.

Actual result: The themes are not visible on AMO. Themes will be displayed on AMO only after editing them (adding an order) from Admin Tools using https://addons-internal.dev.mozaws.net/en-US/admin/models/bandwagon/collection/2143965/change/

Notes: This issue is reproducible on AMO dev and AMO stage with FF63(Win10) with admin and contributor accounts.

add remove

ioanarusiczki commented 5 years ago

I've also noticed that there is this theme https://addons-dev.allizom.org/en-US/firefox/addon/rm-static-theme-3/?src=featured that shows up in the collection but I can't see it in admin tools or the frontend link as being in the collection. I don't know how it got here (this is only on AMO dev)

ioanarusiczki commented 5 years ago

I verified https://github.com/mozilla/addons/issues/12866 and as a followup I'm adding that right now, users cannot edit the Featured Collection using the frontend link https://addons-dev.allizom.org/en-US/firefox/collections/mozilla/featured-personas/ FF64(Win10) and it is reproducible with all permissions

server error

ioanarusiczki commented 5 years ago

I am closing this issue because It's been moved on the front end https://github.com/mozilla/addons/issues/12918

ioanarusiczki commented 5 years ago

After all, it's a server issue and as I mentioned https://github.com/mozilla/addons/issues/12918, other shelf collections have the same problem. I tested with an Admin account the shelf collections such as https://addons-dev.allizom.org/en-US/firefox/collections/4757633/youtube-boosters/?page=1&collection_sort=-added https://addons-dev.allizom.org/en-US/firefox/collections/4757633/health-wellness/?page=1&collection_sort=-added I can add extensions using the front end , but when I go to the homepage the item added is not displayed, strange that I removed a theme (Galaxy of Andromeda) and only after that the theme I added using the link (Eco theme) showed on AMO homepage.

For a better understanding please watch the gif below

frontendlink not working

Reproducible on AMO dev and AMO stage - FF64 (W10) I could not reproduce this issue with the homepage collections from "Customize the way Firefox works with extensions. Are you interested in…" section.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

ioanarusiczki commented 5 years ago

I am going to close this issue. It's a dupe of https://github.com/mozilla/addons/issues/6692 which has been verified.