search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Move RTA kill-switch to db based switch #6361

Closed muffinresearch closed 5 years ago

muffinresearch commented 5 years ago

Since we're now using a DB lookup in https://github.com/mozilla/addons/issues/6346 to check the safe-list for RTA we might as well have the practicality of a DB based switch for Return to AMO. This way we won't need a release to turn it off or on.

AlexandraMoga commented 5 years ago

Verified on AMO -dev with FF65:

With the return-to-amo switch Disabled => any search query with a guid prefixed by rta (except for those cases when the guid contains a @ ) will return a 400 error, with the message "RTA is currently disabled"

With return-to-amo Enabled, the feature is working as expected - i.e if the guid passed in base64url is identified on the TAARDIS safe list, the addon details are returned.