mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Update "All Abuse Reports" view #6556

Closed jvillalobos closed 5 years ago

jvillalobos commented 5 years ago

Part of the the abuse reporting project.

Reviewers can see a list of all abuse reports for an add-on. For example. This needs to be updated to support the additional data logged with the new abuse reports.

The following metadata should be shown, when available:

Per report:

ioanarusiczki commented 5 years ago

@diox Hello Mat, I have a couple of questions regarding this new format for Abuse Reports:

  1. the Version for which the abuse report was made -> is this going to be correctly displayed next to the addon/theme name or it requires a separate column in the new table if or when this https://github.com/mozilla/addons/issues/6554 lands? Right now version is not available in rev tools abuse report page or in admin tools en-US/admin/models/abuse/abusereport/
  2. the Locale is mentioned as being required -> should this be a separate column in the table?
  3. I Installed then reported a couple of add-ons, themes but the Install origin and Install date remained unpopulated fields in the table. I found for a couple of add-ons though such as this one a 2 months, 2 weeks ago at install date and " https://addons-dev.allizom.org/en-US/firefox/addon/fvd-speed-dial/?src=featured Sideload" as install origin. -> Is this going to be implemented later? Also I think that when it will be available it should be the format of the Date (the date the addon was reported) such as April 16, 2019, 3:11 p.m.
  4. Not all users have the country of origin next to their name in the Reporter column, searching through pages all I can say is that it's pretty random meaning there are users that have that information added and users that don't have it.
  5. If the layout is fine, I can't tell, the Report text will be displayed for each abuse report below the rest of the information which has a table format.

layout of the page

  1. I don't know if on this page the More about this add-on and Image Galery sections are of any use. The add-ons display this information again (which is also available on the Review page). Static themes -> they only have an empty Theme Images section, maybe it should be removed completely?

Abuse-reports page for static themes versus addons themes and addons

diox commented 5 years ago
  1. the Version for which the abuse report was made -> is this going to be correctly displayed next to the addon/theme name or it requires a separate column in the new table if or when this https://github.com/mozilla/addons-server/issues/11135 lands? Right now version is not available in rev tools abuse report page or in admin tools en-US/admin/models/abuse/abusereport/

It should be available if it was submitted via the report.

  1. the Locale is mentioned as being required -> should this be a separate column in the table?

We'll adjust if necessary but for now just inside the column that displays the application info is enough

  1. I Installed then reported a couple of add-ons, themes but the Install origin and Install date remained unpopulated fields in the table. I found for a couple of add-ons though such as this one a 2 months, 2 weeks ago at install date and " https://addons-dev.allizom.org/en-US/firefox/addon/fvd-speed-dial/?src=featured Sideload" as install origin. -> Is this going to be implemented later? Also I think that when it will be available it should be the format of the Date (the date the addon was reported) such as April 16, 2019, 3:11 p.m.

Like for version, the info should be there if reported in the abuse report. The challenge for testing is that at the moment, AMO doesn't submit that information. Firefox will, using the updated API (https://github.com/mozilla/addons/issues/6394 and similar issues, + https://bugzilla.mozilla.org/show_bug.cgi?id=1543377)

  1. Not all users have the country of origin next to their name in the Reporter column, searching through pages all I can say is that it's pretty random meaning there are users that have that information added and users that don't have it.

Yes, but there isn't much we can do about it at the moment.

  1. If the layout is fine, I can't tell, the Report text will be displayed for each abuse report below the rest of the information which has a table format.

Yeah I came up with the UI myself and it's a little weird, but I was running out of space. The report text is indeed below the rest of the info.

  1. I don't know if on this page the More about this add-on and Image Galery sections are of any use. The add-ons display this information again (which is also available on the Review page).

Yeah I used the same template. I think it can be useful for context.

ioanarusiczki commented 5 years ago

@diox It's been light now why the version numbers in the abuse reports for some addons from /en-US/admin/models/abuse/abusereport/ is 112.3 for which I filed the issue https://github.com/mozilla/addons/issues/6616. The addon_version can be 112.3, 38.1.44556.788 or any other when I create the report using Postman. With API testing -> I can use the addon_version, app, addon_install_origin and install_date parameters and fill in a value for these. Only install date requires a specific format and app can be either Firefox or Android. Date format and the rest

Followups filed and closing this issue, verified on AMO dev - FF66(Win10).