search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
126 stars 41 forks source link

Editing comments doesn't update #704

Closed marcoagpinto closed 5 years ago

marcoagpinto commented 6 years ago

Describe the problem and steps to reproduce it:

I tried a second editing in a comment to a user of my speller and it didn't update my comment.

What happened?

The text remains the same, my edit takes no effect.

What did you expect to happen?

It should appear my edited comment.

Anything else we should know?

https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary-2

muffinresearch commented 6 years ago

@marcoagpinto Is this the edit or was there another edit that didn't make it?

reviews_for_british_english_dictionary__marco_pinto__ _add-ons_for_firefox
marcoagpinto commented 6 years ago

Yes, @muffinresearch

That edit didn't make it, and the same happened with the one before.

muffinresearch commented 6 years ago

That edit didn't make it, and the same happened with the one before.

@marcoagpinto can you see it now? Is it just the case that you didn't see the update immediately?

marcoagpinto commented 6 years ago

No, it isn't still there :-(

muffinresearch commented 6 years ago

@marcoagpinto some changes are coming soon to the way caching works. This looks like it could be related. Once this issue is fixed https://github.com/mozilla/addons/issues/5324 is fixed and in production this should fix your issue.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.