search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

[Reviewer Tools] Permissions display includes content_scripts matches #7450

Closed erosman closed 4 years ago

erosman commented 4 years ago

Reviewer access example:
https://reviewers.addons.mozilla.org/en-US/reviewers/review/importify

Display: image

It appears that the "content_scripts" -> "matches" are also listed under Permissions display. If that is the intended behaviour, then this is not an issue.

manifest.json: https://reviewers.addons.mozilla.org/en-US/firefox/files/browse/3547349/


{
    "manifest_version": 2,
    "name":    "importify",
    "version": "1.0.4",
  "icons": {
                "16": "icons/icon16.png",
              "48": "icons/icon48.png",
              "128": "icons/icon128.png",
              "129": "icons/icon129.png"
      },
  "web_accessible_resources" : ["icons/tooltip.png", "icons/icon48.png", "icons/loading.gif",
      "icons/icon30.png","icons/btn.png","icons/order.png","icons/login.png","icons/no_image.png",
      "gui.html","custom-description.html", "addresses.html", "aliexpressOrederTracking.html"],
  "content_scripts": [
      {
        "matches": ["*://*.dhgate.com/*","*://*.taobao.com/*","*://*.gearbest.com/*","*://*.dx.com/*",
            "*://*.costco.com/*", "*://*.costco.ca/*","*://*.costco.co.uk/*",
            "*://*.tmall.com/*", "*://*.tmall.hk/*",
            "*://*.dropinthebox.com/*",
            "*://*.lightinthebox.com/*","*://*.miniinthebox.com/*","*://*.wish.com/*",
            "*://*.amazon.com/*","*://*.amazon.ca/*","*://*.amazon.cn/*","*://*.amazon.com.tr/*","*://*.amazon.co.jp/*","*://*.amazon.fr/*",
            "*://*.amazon.de/*","*://*.amazon.it/*","*://*.amazon.ca/*","*://*.amazon.ca/*",
            "*://*.amazon.nl/*","*://*.amazon.ae/*","*://*.amazon.es/*","*://*.amazon.com.mx/*","*://*.amazon.com.au/*",
            "*://*.amazon.com.br/*","*://*.amazon.co.uk/*",
            "*://*.amazon.in/*",
            "*://*.aliexpress.com/*","*://*.aliexpress.ru/*","*://*.icashier.alipay.com/*",
            "*://*.banggood.com/*","*://*.banggood.in/*","*://app.importify.net/*","https://importify.net/*", "*://*.rakuten.com/*","*://*.rakuten.com/*",
            "*://*.etsy.com/*",
            "*://*.dawanda.com/product/*",
            "*://*.sammydress.com/*",
            "*://*.tmart.com/*",
            "*://*.myip.ms/*",
            "https://*/products/*",
            "*://*/product/*",
            "*://*/*/checkouts/*",
            "*://*/cart*",
            "*://*/?fbspy",
            "*://*/collections/*/products/*",
            "*://*/admin/orders/*",
            "*://*.dresslily.com/*",
            "*://*.rosegal.com/*",
            "*://*.wonify.store/*",
            "*://*.myshopify.com/*",
            "*://*.alibaba.com/*",
            "*://*.walmart.com/*",
            "*://*.walmart.ca/*",
            "*://*.overstock.com/*",
            "*://*.snapdeal.com/*",
            "*://*.1688.com/*",
            "*://*.wayfair.com/*",
            "*://*.sunfrog.com/*",
            "*://*.tomtop.com/*",
            "*://*.sears.com/*",
            "*://*.geekbuying.com/item/*",
            "*://*.shein.com/*",
            "*://*.shein.in/*",
            "*://*.shein.co.uk/*",
            "*://*.flipkart.com/*",
            "*://*.wonify.com/*",
            "*://*.www.buyincoins.com/item/*.html",
            "*://*.opticsplanet.com/*.html*",
            "*://*.rosewholesale.com/*.html*",
            "*://*.allstarhealth.com/*",
            "*://*.fasttech.com/products/*",
            "*://*.kohls.com/product/*",
            "*://*.item.jd.com/*html*",
            "*://*.globalsources.com/*",
            "*://*.chinabrands.com/*",
            "*://*.ltdcommodities.com/*",
            "*://*.bonanza.com/*",
            "*://*.macys.com/shop/product/*",
            "*://*.ioffer.com/i/*",
            "*://*.nordstrom.com/*",
            "*://*.cdiscount.com/*",
            "*://*.emmacloth.com/*",
            "*://*.gogomall.com/product/*",
            "*://*.trendsgal.com/p/*",
            "*://*.trade.aliexpress.com/orderList.htm/*",
            "*://*.colourblocker.com.au/*",
            "*://*.myshopify.com/admin/orders/*/fulfill_and_ship/*",
            "*://*.partycity.com/*",
            "*://*.blinq.com/*",
            "*://*.fancy.com/*",
            "*://*.lightake.com/*",
            "*://*.shopbop.com/*",
            "*://*.tanga.com/*",
            "*://*.lazada.sg/*",
            "*://*..lazada.co.id/*",
            "*://*.lazada.vn/*",
            "*://*.lazada.co.th/*",
            "*://*.lazada.com.ph/*",
            "*://*.fashiongo.net/*",
            "*://*.lashowroom.com/*",
            "*://*.rubyimports.net/*",
            "*://*.cjdropshipping.com/*"
        ],
        "js": [
          "libs/jquery-2.2.4.min.js",
          "js/importify-handlebars.js",
          "js/change-price.js",
          "js/functions.js",
          "js/country.js",
          "js/content.js",
          "js/shopifySites.js",
          "js/dhgate.js",
          "js/alibaba.js",
          "js/taobao.js",
          "js/gearbest.js",
          "js/geekbuying.js",
          "js/shein.js",
          "js/lightinthebox.js",
          "js/buyincoins.js",
          "js/bangood.js",
          "js/rakuten.js",
          "js/costco.js",
          "js/opticsplanet.js",
          "js/rosewholesale.js",
          "js/allstarhealth.js",
          "js/overrideProduct.js",
          "js/fasttech.js",
          "js/kohls.js",
          "js/jd.js",
          "js/etsy.js",
          "js/ltdcommodities.js",
          "js/bonanza.js",
          "js/lazada.js",
          "js/walmart.js",
          "js/wayfair.js",
          "js/wish.js",
          "js/dawanda.js",
          "js/flipkart.js",
          "js/globalsources.js",
          "js/chinabrands.js",
          "js/amazon.js",
          "js/woocommerce.js",
          "js/jquery.dataTables.min.js",
          "js/modal.js",
          "js/colourblocker.js",
          "js/ioffer.js",
          "js/nordstrom.js",
          "js/cdiscount.js",
          "js/emmacloth.js",
          "js/trendsgal.js",
          "js/myip.js",
          "js/macys.js",
          "js/gogomall.js",
          "js/partycity.js",
          "js/fashiongo.js",
          "js/lashowroom.js",
          "js/blinq.js",
          "js/fancy.js",
          "js/tanga.js",
          "js/shopbop.js",
          "js/lightake.js",
          "js/cjdropshipping.js",
          "js/rubyimports.js",
          "js/dresslily.js",
          "js/rosegal.js"

        ],
        "css":  [
          "libs/fix.css",
          "libs/css/gui.css",
          "libs/css/modal.css",
          "libs/css/datatables.min.css"
        ]
    },
      {
        "matches": ["https://app.importify.net/dashboard/import-product/iframe-description?description*"],
        "all_frames": true,
        "js": [   "libs/jquery-2.2.4.min.js","libs/custom-description-iframe.js"]
      },
      {
        "matches": [
          "*://detail.tmall.com/*",
          "*://world.tmall.com/*",
          "*://detail.tmall.hk/*",
          "*://detail.1688.com/*",
          "*://item.taobao.com/*"
        ],
        "all_frames": true,
        "js": [ "libs/jquery-2.2.4.min.js",
          "js/translateContent.js"]
      }],
     "background": {
     "scripts": [
       "libs/jquery-2.2.4.min.js",
       "libs/moment.min.js",
       "libs/bootstrap/js/bootstrap.min.js",
       "js/background.js",
       "js/translate.js",
       "js/popup.js"
     ]
    },
   "permissions": [
    "tabs" ,"contextMenus","activeTab","webRequest","<all_urls>","management","storage"
    ],
  "browser_action": {
          "default_icon": "icons/icon48.png",
          "default_popup": "popup.html"
  }
}
--
jvillalobos commented 4 years ago

This is intentional. See https://github.com/mozilla/addons/issues/13005