mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Manual approval for an addon/theme won't work #7584

Closed ioanarusiczki closed 4 years ago

ioanarusiczki commented 4 years ago

STR:

  1. With an admin account load AMO dev or AMO stage and try to approve an add-on or a static theme https://reviewers.addons.allizom.org/en-US/reviewers/review/name45

Expected result: The addon/theme is approved.

Actual result: A 504 Gateway Time-out is displayed.

Notes: I could reproduce the issue on AMO dev and AMO stage with FF76(win10). The issue is not reproducible for the Reject button.

ioanarusiczki commented 4 years ago

@diox A new addon https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/search-by-image5191

diox commented 4 years ago

https://sentry.prod.mozaws.net/operations/olympia-dev/issues/8479592/?query=is%3Aunresolved

SigningError: Posting to add-on signing failed: GATEWAY_TIMEOUT 

Exception(most recent call first)

SigningError: Posting to add-on signing failed: GATEWAY_TIMEOUT 
  File "django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "olympia/amo/decorators.py", line 30, in wrapper
    return func(request, *args, **kw)
  File "olympia/reviewers/decorators.py", line 69, in wrapper
    return f(request, *args, **kw)
  File "olympia/addons/decorators.py", line 51, in wrapper
    return f(request, addon, *args, **kw)
  File "olympia/reviewers/views.py", line 805, in review
    form.helper.process()
  File "olympia/reviewers/utils.py", line 563, in process
    return self.actions[action]['method']()
  File "olympia/reviewers/utils.py", line 781, in process_public
    self.sign_files()
  File "olympia/reviewers/utils.py", line 759, in sign_files
    sign_file(file_)
  File "olympia/lib/crypto/signing.py", line 179, in sign_file
    cert_serial_num = str(call_signing(file_obj))
  File "olympia/lib/crypto/signing.py", line 120, in call_signing
    raise SigningError(msg)
diox commented 4 years ago

Same on stage https://sentry.prod.mozaws.net/operations/olympia-stage/issues/8481644/?query=is%3Aunresolved

smarnach commented 4 years ago

@ioanarusiczki We believe the problem has been fixed on the Autograph side. Can you please try again?

ioanarusiczki commented 4 years ago

@diox It is still reproducible right now on dev and stage.

smarnach commented 4 years ago

@ioanarusiczki Thanks for checking! Autograph ops found another problem. We will let you know once it is fixed.

smarnach commented 4 years ago

@ioanarusiczki Ops made another change. Could you please try again?

ioanarusiczki commented 4 years ago

@smarnach Same result I'm afraid. 504 Gateway Time-out

smarnach commented 4 years ago

@ioanarusiczki Thanks again, and sorry for the trouble! We'll try to figure out what's going on.

ioanarusiczki commented 4 years ago

@smarnach I'm updating: seems to be working now on both testing servers.

smarnach commented 4 years ago

Great to hear, and thanks for your patience!