search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Add details of promoted status to xpi when signing #7760

Closed eviljeff closed 4 years ago

eviljeff commented 4 years ago

When an add-on is added to either of the Verified or Line lists (not Spotlight), it should be reflected in the mozilla-recommendations.json file when signed, under “states” (values: “sponsored” for Verified tier 1, “verified” for Verified tier 2, “line” for Line).

eviljeff commented 4 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1657419 for autograph work

AlexandraMoga commented 4 years ago

@eviljeff I don't see the mozilla-recommendations.json file being created after approving an add-on belonging to the promoted categories mentioned above. Example of a Verified - Tier 1 approved add-on: https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/cancel-and-disable1

The fie is being created for recommended add-ons, as before.

eviljeff commented 4 years ago

sorry, forgot to mention there's a waffle autograph_promoted_signer - and it relies on upstream config changes I added in autograph (which have landed in their repo... but I'll need to check their deployment schedule and what server we use on addons-dev)

eviljeff commented 4 years ago

@AlexandraMoga the autograph changes are live. If the waffle is enabled on AMO it should work

AlexandraMoga commented 4 years ago

Add-ons from the categories enumerated below will receive the mozilla-recommendations.json file when they are signed and will have the following states:

The mozilla-recommendations.json is not created for unlisted versions belonging to these promoted add-ons.

Strategic and Spotlight add-ons will be signed normally, i.e. they won't receive a mozilla-recommendations.json file.

I'm marking this issue as verified fixed on -dev.