search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
123 stars 53 forks source link

Category sorting by most users not working #8274

Closed tublitzed closed 2 years ago

tublitzed commented 3 years ago

Describe the problem and steps to reproduce it:

I went to this page and expected to see the default sort applied (by "most users") - scrolling down the list, I see add-ons like Facebook Container and Grammarly both have 1M+ users and are displayed below items like LastPass (~800k users) and RoboForm Password Manager (~75k users).

What happened?

Sorting not working

What did you expect to happen?

Sorting working :)

Anything else we should know?

Screen Shot 2021-04-05 at 10 32 34 AM

AlexandraMoga commented 3 years ago

Category pages are using a special ?sort=recommended%2Cusers parameter, which means we are first displaying all the recommended add-ons within the selected category sorted by users followed by all other add-ons from the same category also sorted by users.

The implementation was done in https://github.com/mozilla/addons-frontend/pull/8103

bobsilverberg commented 3 years ago

Thanks @AlexandraMoga! That is correct and this is the expected behaviour. I'm going to close this for now, but please let me know if you have any questions about it, @tublitzed.

jvillalobos commented 3 years ago

I think there's a good argument to be made that the Sort label is confusing. If you change the sort to something else and then back to Most Users, the end result will be different than where you started.

Perhaps we should add a Sort option called Most Users, Recommended First that is chosen in this case. I'm aware that the special Recommended sorting can be mixed up with all other sort options, but I believe Most Users is the only one we mix it up with on the site, so we can make an exception for it.

eviljeff commented 3 years ago

If you change the sort to something else and then back to Most Users, the end result will be different than where you started.

I'm not following, can you include STR for this - changing the filters and then changing back shows the same results for me.

Perhaps we should add a Sort option called Most Users, Recommended First that is chosen in this case. I'm aware that the special Recommended sorting can be mixed up with all other sort options, but I believe Most Users is the only one we mix it up with on the site, so we can make an exception for it.

We do recommend first for all the sort by options (like @AlexandraMoga mentions)

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.