drop `is_webextension` from File model

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

127 stars 41 forks source link

drop `is_webextension` from File model #8499

Closed eviljeff closed 3 years ago

eviljeff commented 3 years ago

All add-ons have been webextensions for years on AMO prod, and we dropped support for parsing installing rdfs in mozilla/addons#8248 a few months back, effectively stopping any new uploads even by admins. We should drop the actual model field, and any lingering supporting code that differentiates between webextension files and non-webextension files.

https://sql.telemetry.mozilla.org/queries/82037/source shows 43 files remaining that are webextension=False. (They will either need to be deleted beforehand, or in the migration)

For QA:

please verify that git extraction continues to exclude non web-extension files (like themes, langpacks, dicts) as per https://github.com/mozilla/addons/issues/7573
please re-verify the following issue: https://github.com/mozilla/addons/issues/7499

willdurand commented 3 years ago

sql.telemetry.mozilla.org/queries/82037/source shows 43 files remaining that are webextension=False. (They will either need to be deleted beforehand, or in the migration)

Should we track this separately? When should we expect to delete these files? cc @wagnerand

eviljeff commented 3 years ago

triggering the deletes with a migration is possible, but it wouldn't be a bad idea to investigate why they're still there. I'm pretty sure they're files from disabled versions but haven't confirmed that for each file.

wagnerand commented 3 years ago

Those files are signed with the privileged cert. Since they won't run in any recent version of Firefox, I think it's safe to delete them.

ioanarusiczki commented 3 years ago

@eviljeff I verified this on -dev and -stage:

the git extraction is working fine - as described inhttps://github.com/mozilla/addons/issues/7573
scanner results work as described https://github.com/mozilla/addons/issues/7499 on AMO stage. On AMO dev the results are not the same with stage, meaning that I did not see mad being triggered when a langpack, dict or other extensions with matching rules are scanned and custom will show n/a as score in this case.

ioanarusiczki commented 3 years ago

@eviljeff

I talked with @willdurand and filed a followup for MAD https://github.com/mozilla/addons/issues/8526

Since AMO stage looks good I think this can be marked verified - FF92(Win10).