search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Auto-approvals are not working on AMO -dev #9164

Closed AlexandraMoga closed 1 year ago

AlexandraMoga commented 1 year ago

Describe the problem and steps to reproduce it:

  1. Upload a new unlisted addon or a new listed addon version - the scope is to upload an addon that would normally be auto-approved without any delays
  2. Wait for the add-on to be auto-approved

What happened?

The auto-approval doesn't run in the expected amount of time (~5 mins intervals). Addon remains in Awaiting Review status.

What did you expect to happen?

Addons should be auto-approved

Anything else we should know?

diox could this regression be caused by https://mozilla-hub.atlassian.net/browse/SVCSE-1212?

┆Issue is synchronized with this Jira Task

diox commented 1 year ago

Possibly related yes.

Other failures that are definitely caused by this change:

Maybe the celery worker instances (servers processing tasks) and admin instances (server processing recurring jobs like auto-approval) were not restarted after this config change ? Or maybe the path is still hardcoded somewhere else in the settings.

diox commented 1 year ago

@AlexandraMoga logs do say there was a signing error. Is manual approval broken too (using a different add-on) ?

AlexandraMoga commented 1 year ago

@diox manual approvals from RevTools are working.

diox commented 1 year ago

@AlexandraMoga could you try again with new versions ?

AlexandraMoga commented 1 year ago

@diox new submissions will be auto-approved but the ones uploaded yesterday are still stuck in Awaiting Review.

diox commented 1 year ago

Yeah those files are busted. You can disable the versions, they'll never work properly.

KevinMind commented 4 months ago

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-344