search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
126 stars 41 forks source link

Investigate why the InstallButton connect can break the tests #9604

Closed mstriemer closed 8 years ago

mstriemer commented 8 years ago

In the mapStateToProps for InstallButton there is a line (state.installations || {}). If the or is removed then the tests break without running anything and the error message is not useful. There is likely a render happening outside of a beforeEach() or it() block that needs to move into a beforeAll() (or whatever it is in mocha).

mstriemer commented 8 years ago

The tests no longer break without the || {}, so I guess this is fixed now.