Fix bug where user can't close pop up because of sticky header

mozilla / advocacy.mozilla.org

https://advocacy.mozilla.org

Mozilla Public License 2.0

199 stars 34 forks source link

Fix bug where user can't close pop up because of sticky header #505

Closed beccaklam closed 6 years ago

beccaklam commented 6 years ago

[ ] Found a bug on mobile where when the pop up comes because of the sticky header the user can't close the pop up and essentially is stuck on the page. This should probably get fixed:

alanmoo commented 6 years ago

STR:

On pni-refresh branch, navigate to a product page on mobile (http://localhost:8080/privacynotincluded/category/toys/edwintheduck
Start scrolling.

(I think this is tied to sessionStorage, so you may have to open in a private tab)

Pomax commented 6 years ago

Ah, this only occurs when the browser window is smaller than the popup notice; I've adjusted the z-index for the modal so that it sits on top of all page content, even on small screens, which should resolve this.

alanmoo commented 6 years ago

Landed in master, thanks @Pomax