mozilla / aframe-xr

INACTIVE - http://mzl.la/ghe-archive - System / Components to build WebXR experiences with A-frame
https://mozilla.github.io/aframe-xr/
MIT License
184 stars 36 forks source link

To make it clearer that there are 3 scripts to include #11

Closed poshaughnessy closed 6 years ago

poshaughnessy commented 6 years ago

Hi. The README currently says: Include three.xr.js & aframe-xr after A-frame.... But the code example currently looks like this:

<script src="../../../vendor/aframe-master.js"></script>
<script src='aframe-xr.js'></script>

So I thought I just needed to include aframe-master.js and aframe-xr.js.

Also, taking a look at the xr-basic example caused me some temporary further confusion, because the aframe-master.js script tag is off-screen, over the right-hand side, after the origin trial tag.

So this PR is my recommendation for extra newbie-friendliness:

WDYT? :)

blairmacintyre commented 6 years ago

Looks good! (sorry about the script tag being on the end of the line with the origin trial script, that was my recent flub, thanks for catching it.)

poshaughnessy commented 6 years ago

Thanks!