Does not like paths with spaces

mozilla / apk-cli

A Command Line Inteface for generating Android native apps from open webapps

59 stars 9 forks source link

Does not like paths with spaces #2

Closed feklee closed 10 years ago

feklee commented 10 years ago

Example error message (Windows):

Unable to unzip d:\Dropbox\Temp Work\Theta_experiment\app\package\package.zip { [Error: Command failed: unzip:  cannot find either d:/Dropbox/Temp or d:/Dropbox/Temp.zip. ] killed: false, code: 9, signal: null }

A couple of quotes here and there should solve the problem.

ozten commented 10 years ago

As a workaround, can you put your code in a directory structure without spaces?

I'll attempt to reproduce soon. Will add quotes, as we use child_process.exec which takes a string and doesn't handle the OS level escaping.

ozten commented 10 years ago

Fixed in 25beadbd561e7ae45b4336ff6d2464018ff4d717

Available in version 0.0.8 on npm.

Thanks!

feklee commented 10 years ago

That was quick - thanks!

(Yes, I worked around the issue by putting code in a directory structure without spaces.)