search

mozilla / apk-factory-service

Web service which converts Open Web Apps into native Android apps
41 stars 18 forks source link

Update to manifest causes HTTP errors on first request #24

Closed ozten closed 10 years ago

ozten commented 10 years ago

Steps to Reproduce

1) Request an APK

2) Update the known manifest hash

update apk_metadata set  manifest_hash = 'foo' ;

3) Request the APK again

error: uncaughtException: Can't set headers after they are sent. date=Tue Jan 07 2014 15:06:57 GMT-0800 (PST), pid=32550, uid=1000, gid=1000, cwd=/home/ozten/apk-factory-service, execPath=/usr/local/bin/node, version=v0.10.15, argv=[node, /home/ozten/apk-factory-service/bin/controller], rss=31780864, heapTotal=31127296, heapUsed=17013832, loadavg=[0.3115234375, 0.2890625, 0.23046875], uptime=14703580.164790167, trace=[column=11, 
file=http.js, function=ServerResponse.OutgoingMessage.setHeader, line=707, method=OutgoingMessage.setHeader, native=false, column=22, 
file=/home/ozten/apk-factory-service/node_modules/express/node_modules/connect/lib/patch.js, function=ServerResponse.res.setHeader, line=59, method=res.setHeader, native=false, column=10, 
file=/home/ozten/apk-factory-service/node_modules/express/lib/response.js, function=ServerResponse.res.set.res.header, line=522, method=res.set.res.header, native=false, column=15, 
file=/home/ozten/apk-factory-service/node_modules/express/lib/response.js, function=ServerResponse.res.contentType.res.type, line=394, method=res.contentType.res.type, native=false, column=11, 
file=/home/ozten/apk-factory-service/bin/controller, function=null, line=44, method=null, native=false, column=11, 
file=/home/ozten/apk-factory-service/lib/front_controller.js, function=null, line=112, method=null, native=false, column=7, 
file=/home/ozten/apk-factory-service/lib/apk_cache.js, function=null, line=115, method=null, native=false, column=9, 
file=/home/ozten/apk-factory-service/lib/front_controller.js, function=genCb, line=107, method=null, native=false, column=11, 
file=/home/ozten/apk-factory-service/lib/apk_generator.js, function=null, line=58, method=null, native=false, column=9, 
file=/home/ozten/apk-factory-service/lib/apk_project_builder.js, function=antCb, line=225, method=null, native=false], 
stack=[Error: Can't set headers after they are sent.
,     at ServerResponse.OutgoingMessage.setHeader (http.js:707:11)
,     at ServerResponse.res.setHeader (/home/ozten/apk-factory-service/node_modules/express/node_modules/connect/lib/patch.js:59:22)
,     at ServerResponse.res.set.res.header (/home/ozten/apk-factory-service/node_modules/express/lib/response.js:522:10)
,     at ServerResponse.res.contentType.res.type (/home/ozten/apk-factory-service/node_modules/express/lib/response.js:394:15)
,     at /home/ozten/apk-factory-service/bin/controller:44:11
,     at /home/ozten/apk-factory-service/lib/front_controller.js:112:11
,     at /home/ozten/apk-factory-service/lib/apk_cache.js:115:7
,     at genCb (/home/ozten/apk-factory-service/lib/front_controller.js:107:9)
,     at /home/ozten/apk-factory-service/lib/apk_generator.js:58:11
,     at antCb (/home/ozten/apk-factory-service/lib/apk_project_builder.js:225:9)]
npm ERR! weird error 1
npm ERR! not ok code 0
ozten commented 10 years ago

Fixed in ca4d779