WIP Bug#974692 Selectively resolve mini manifest urls

mozilla / apk-factory-service

Web service which converts Open Web Apps into native Android apps

41 stars 18 forks source link

Closed ozten closed 10 years ago

ozten commented 10 years ago

This part of the original prototype seemed dodgy.

Some places, we need a canonical url and others it sounds like we need to maintain it's original form.

Getting this wrong could defeat caching layers.

A cursory check, this seems correct. Maybe we can see if this seems to fix Bug#974692

kumar303 commented 10 years ago

Looks good to me. Is there an easy way to add tests so that it doesn't break in future refactoring?

kumar303 commented 10 years ago

Let's try this patch

ozten commented 10 years ago

Yes, I definately will add a test for manifest URLs with query string parameters.