FileLoader.copy should use a buffer instead of string

mozilla / apk-factory-service

Web service which converts Open Web Apps into native Android apps

42 stars 18 forks source link

FileLoader.copy should use a buffer instead of string #86

Closed dannycoates closed 9 years ago

dannycoates commented 9 years ago

This was an oversight of #82.

I assumed incorrectly that an unset encoding in request would use a buffer but it must be explicitly set to null.

@kumar303 r?

cc @asdofindia @kyoshino

kumar303 commented 9 years ago

It would be nice if there were something more direct like useBuffer=true but I don't know the requests module well enough. It sounds like the right thing to do.