search

mozilla / application-services

Firefox Application Services
https://mozilla.github.io/application-services/
Other
608 stars 225 forks source link

Coverage reports broken due to nightly bustage in a dependency #3851

Closed rfk closed 3 years ago

rfk commented 3 years ago

Our coverage reports use ~cargo-tarpaulin~ grcov, which means they have to run on Nightly Rust. Nightly Rust recently stabilized the ::BITS associated constant on integer types. One of our downstream dependencies had a conflicting trait implementation that also defined a ::BITS constant, so now that dependency fails to build on Nightly Rust and our coverage reports don't run.

I don't think there's much we can do here apart from wait for an updated release of lexical-core, but I wanted to put it on file for completeness.

┆Issue is synchronized with this Jira Task ┆Sprint: Backlog

HTGAzureX1212 commented 3 years ago

It also affected my project so I just cloned the repository (the lexical-core repository), made the fixes and using the [patch] section in Cargo.toml to use the lexical-core on my computer with my fix instead of the one on crates.io which is broken.

rfk commented 3 years ago

Thanks @HTG-YT, and thanks for your work to track down the underlying cause here in the linked bugs!