search

mozilla / assay

A Firefox Addons review tool disguised as a VSCode extension
Mozilla Public License 2.0
6 stars 3 forks source link

Remove commenting functionality #90

Closed abyrne-moz closed 1 month ago

abyrne-moz commented 1 month ago

Remove the commenting functionality from Assay, so that it is only used as a version inspection and comparison tool.

chrstinalin commented 1 month ago

This is possible, I'd just like to note it's removing a significant chunk of the codebase (and the possibility of causing some issues, as Assay is essentially built around the commenting system).

Is there no situation in which the commenting is useful? Would the ability to right click to mark lines be beneficial on top of the existing commenting rather than in stead of?

abyrne-moz commented 1 month ago

The primary goal of Assay is to replace the online code manager tool, and the reviewers do not use any commenting system in there to my knowledge. After speaking with @willdurand, @wagnerand and @abhn we decided it would be best to remove code for features that will not be used to make the codebase smaller, easier to maintain and reduce the risk of bugs.

chrstinalin commented 1 month ago

@abyrne-moz There is technically one, but it's not the first time I've heard that it wasn't being used. image