mozilla / audioipc

Cubeb Audio Remoting For Gecko
10 stars 17 forks source link

client: Make shmem and input copy allocations fallible, signal error to server on failure #126

Closed kinetiknz closed 3 years ago

kinetiknz commented 3 years ago

Add error message to CallbackReq for signalling client-side callback errors. Handle this on the server side when waiting for shmem setup to complete.

This addresses the OOM-related crashed for 32-bit Windows in BMO 1730518. This should be simple/safe enough to uplift to beta 94.

I'm testing a follow-up fix/improvement that sizes the shmem appropriately for each stream - I'll post the PR soon. That's more experimental, so I intend to land that only in nightly.