search

mozilla / audioipc

Cubeb Audio Remoting For Gecko
10 stars 17 forks source link

Core IPC messaging rewrite. #130

Closed kinetiknz closed 2 years ago

kinetiknz commented 2 years ago

Replaces tokio 0.1 with mio 0.7-based system. Full description in old draft PR.

Part 1 includes the new IPC core, intended to replace the existing tokio 0.1 IPC core. Part 2 integrates the new IPC core into the rest of the server and client code. Part 3 removes the old tokio 0.1 core (including resolving mio 0.6 vs 0.7 dependency duplication).

These changes will be initially merged into the https://github.com/mozilla/audioipc-2/tree/macos branch, which can then be integrated with Gecko for the macOS build only. Once any remaining issues have been resolved, the macos branch will be merged to master and Linux and Windows will switch to the new IPC core.

kinetiknz commented 2 years ago

Thanks for the great feedback! Really appreciate the time and thought you've put in to this. I've addressed most of your comments now (forgot to re-request review when I pushed changes on Monday 🤦‍♂️). I'll keep working on the few that are still outstanding and put them up soon.