mozilla / audioipc

Cubeb Audio Remoting For Gecko
10 stars 17 forks source link

please backport fix for Disable audio_thread_priority default features #157

Closed stefson closed 2 years ago

stefson commented 2 years ago

hi there,

there is a linking error when compiling firefox without dbus support, and I believe that this is the place to ask the fix to be backported so that it will be backported automatically into the firefox source code tree:

https://github.com/kinetiknz/audioipc/pull/5/

for more information on the bug, see https://bugzilla.mozilla.org/show_bug.cgi?id=1773336

thank you

kinetiknz commented 2 years ago

Sorry about the delay! I'll be merging this fix along with a number of other changes to Gecko in the next few days.

stefson commented 2 years ago

no worries, as long as its queued to be fixed! :-)

affected are: 103.0 stable, 104.0 beta and 105.0 nightly

kinetiknz commented 2 years ago

It'll land via https://bugzilla.mozilla.org/show_bug.cgi?id=1781993, so I'll close this issue.

stefson commented 2 years ago

@kinetiknz thanks for the update, I just noticed there are many fixes for third_party/rust/audioipc2 and none for third_party/rust/audioipc in that mozilla pull request?

kinetiknz commented 2 years ago

Thanks, I've backported the fix to the old branch and it'll land via https://bugzilla.mozilla.org/show_bug.cgi?id=1782147 shortly.