mozilla / audioipc

Cubeb Audio Remoting For Gecko
10 stars 17 forks source link

Bump audio_thread_priority to 0.32. #175

Closed yjugl closed 7 months ago

yjugl commented 7 months ago

Fixed the following nightly clippy warnings:

warning: the item `bincode` is imported redundantly
  --> audioipc\src\codec.rs:13:15
   |
13 | use bincode::{self, Options};
   |               ^^^^ the item `bincode` is already defined by prelude
   |
   = note: `#[warn(unused_imports)]` on by default

warning: the item `cubeb` is imported redundantly
  --> audioipc\src\messages.rs:11:13
   |
11 | use cubeb::{self, ffi};
   |             ^^^^ the item `cubeb` is already defined by prelude

warning: `audioipc2` (lib) generated 2 warnings
warning: item has both inner and outer attributes
  --> server\src\lib.rs:37:1
   |
37 | / #[allow(deprecated)]
38 | | pub mod errors {
39 | |     #![allow(clippy::upper_case_acronyms)]
   | |__________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style
   = note: `#[warn(clippy::mixed_attributes_style)]` on by default

warning: the item `From` is imported redundantly
  --> server\src\server.rs:19:20
   |
19 | use std::convert::{From, TryInto};
   |                    ^^^^
  --> /rustc/f4b771bf1fb836392e1c510a625cdc81be09c952\library\std\src\prelude\mod.rs:115:13
   |
   = note: the item `From` is already defined here
   |
   = note: `#[warn(unused_imports)]` on by default

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
   --> server\src\lib.rs:162:9
    |
162 |         params.context_name = CStr::from_ptr(context_name).to_owned();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `CStr::from_ptr(context_name).clone_into(&mut params.context_name)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `#[warn(clippy::assigning_clones)]` on by default

warning: `audioipc2-server` (lib) generated 3 warnings (run `cargo clippy --fix --lib -p audioipc2-server` to apply 1 suggestion)
warning: the item `cubeb` is imported redundantly
 --> ipctest\src\client.rs:6:13
  |
6 | use cubeb::{self, ffi, Sample};
  |             ^^^^ the item `cubeb` is already defined by prelude
  |
  = note: `#[warn(unused_imports)]` on by default