client: Handle shmem setup error gracefully.

mozilla / audioipc

Cubeb Audio Remoting For Gecko

10 stars 17 forks source link

Closed kinetiknz closed 4 years ago

kinetiknz commented 4 years ago

This could fail due to low available address space (for example), so unwrapping the Result is inappropriate.

This is intended to be a fix for BMO 1621360.

r? @ChunMinChang please

kinetiknz commented 4 years ago

Thanks for the review.

Is the cause that fails to open shm found?

Bug 1621360 comment 6 is my best answer, for now. I don't know if the high failure rate is directly due to this error or some other underlying issue.

Edit: I'm also working on https://github.com/djg/audioipc-2/issues/45 as a secondary improvement in this area.