mozilla / authenticator-rs

Rust library to interact with Security Keys, used by Firefox
https://crates.io/crates/authenticator
Mozilla Public License 2.0
275 stars 72 forks source link

Dont ignore cached PUATs for devices < FIDO_2_1 #308

Closed msirringhaus closed 1 year ago

msirringhaus commented 1 year ago

The caching didn't work for devices that do not yet support the permissions-system. We can ignore the permissions, if we are in legacy-mode or on a device not implementing full-blown 2.1

Yes, "using legacy" and "not having full-blown 2.1" should be interchangeable, but are not always. My nitrokey3 for example reports to only implement 2_1_PRE, but also reports to implement both the Preview and the full credentialManagement-command. Probably a bug on their side, but it doesn't us hurt to check both.

Also, in the last PR I forgot the == vs. contains()-fix for CredentialManagement and AuthConfiguration.