search

mozilla / authenticator-rs

Rust library to interact with Security Keys, used by Firefox
https://crates.io/crates/authenticator
Mozilla Public License 2.0
273 stars 70 forks source link

Add Raw Auth Data #322

Closed obelisk closed 9 months ago

obelisk commented 9 months ago

To verify the signature, I've been unable to make that work using the serialize function because I don't believe Ser(DeSer(auth_data)) = auth_data.

This is not in a state to merge as I've just commented out a bunch of tests because I haven't figured out what the vector for them should be yet, but I wanted to get this in front of your guys in case I'm missing something or this is an unacceptable change for some reason.

Closes #282

jschanck commented 9 months ago

Do you have a test case for which Ser(DeSer(auth_data)) != auth_data?

obelisk commented 9 months ago

Looks like I was mistaken. I was fairly sure I tested this yesterday but I must have been wrong. The issue a few months ago was that I think elements from map were missing or in a different order but I just tested it with a Yubikey BIO and 5Cn and it was correct.

I'll reopen if I find any place where this doesn't hold. Sorry for the noise.