mozilla / bedrock

Making mozilla.org awesome, one pebble at a time
https://www.mozilla.org
Mozilla Public License 2.0
1.17k stars 913 forks source link

Lockwise copy is shown when trying to download Firefox using Firefox. #10795

Closed alexgibson closed 2 years ago

alexgibson commented 2 years ago

Description

The Firefox Account popup on /firefox/new/ still mentions Lockwise.

Steps to reproduce

  1. Using Firefox (not signed into an FxA account), open https://www.mozilla.org/en-US/firefox/new/.
  2. Click "Download Firefox".
  3. Observe the popup that gets shown.
image

Expected result

The popup should not mention Lockwise.

Actual result

The popup mentions Lockwise.

Also note that bug https://github.com/mozilla/bedrock/issues/9866 is still present

Environment

Firefox

reemhamz commented 2 years ago

Hmm, this modal only shows up when I'm using Firefox Developer. When using regular Firefox or Nightly, it just takes me to the download page. Isn't this modal action supposed to span through all Firefox browsers?

alexgibson commented 2 years ago

@reemhamz it’s conditional to being signed into FxA.

alexgibson commented 2 years ago

@slightlyoffbeat this bug has been open for a while now - do we have something else we'd like to say here in place of mentioning Firefox Lockwise? If not, is this modal providing any real value still if we removed the copy underneath the title?

slightlyoffbeat commented 2 years ago

Lets update to:

Watch for hackers with Firefox Monitor, protect your email address with with Firefox Relay, and more