search

mozilla / bedrock

Making mozilla.org awesome, one pebble at a time
https://www.mozilla.org
Mozilla Public License 2.0
1.17k stars 912 forks source link

Use protocol standards on global Pocket components #11735

Closed maureenlholland closed 1 year ago

maureenlholland commented 2 years ago

As noted in the Pocket legal-docs PR https://github.com/mozilla/bedrock/issues/11723, we can get some odd indentation between nav/main/footer content because they aren't all using the Protocol content tokens.

Ideally, we can clean up the nav and footer a bit to avoid hardcoded values and get some consistency through Protocol tokens. Or at least Pocket-specific shared variables.

Success Criteria:

maureenlholland commented 2 years ago

👋 I'm going to un-assign myself for about a month to work on something more time-sensitive. I started a branch but didn't get very far: https://github.com/maureenlholland/bedrock/tree/11735-use-protocol-standards-on-global-pocket-components

If anyone else wants to pick this up, feel free.

maureenlholland commented 1 year ago

Closing in favour of waiting for unified header/footer components before putting more effort into refactoring (i.e. no variation of header/footer depending on if you are on a platform page or not)