Fixes for pocket /add page

mozilla / bedrock

Making mozilla.org awesome, one pebble at a time

https://www.mozilla.org

Mozilla Public License 2.0

1.18k stars 916 forks source link

Fixes for pocket /add page #12494

Closed maureenlholland closed 1 year ago

maureenlholland commented 1 year ago

Description

There are a few significant differences between the marketing /add page and pocket prod /add page

Success Criteria

[ ] Headline goes full width to avoid overlarge vertical spacing gaps
[ ] We confirm the integrated app section links and fix "Integreated" typo (EN only)
[ ] Check with Pocket team on altering their CDN routing to use marketing page

See https://github.com/mozilla/bedrock/issues/12925 for more detail on why we can't update CDN routing yet

Ayush-Kori commented 1 year ago

Hello @maureenlholland Can u assign ths issue to me ??

maureenlholland commented 1 year ago

Hi @Ayush-Kori, sorry for the delayed response. Are you still interested in working on this issue?

Ayush-Kori commented 1 year ago

Yes

maureenlholland commented 1 year ago

Great! @Ayush-Kori You'll need to Install Bedrock and run it in Pocket Mode to see the page in question locally.

The main issue is getting the heading to go full-width. We are currently using a Protocol split component and it doesn't quite work for the styling we need. You can remove that component and use plain HTML with flex or grid to get the image and content below the heading to line up side-by-side on larger screen sizes.

The app section links are good (the removed links were no longer working), but we'll need to fix the English spelling in the FTL file: https://github.com/mozilla/bedrock/blob/main/l10n-pocket/en/pocket/add.ftl#L42

Feel free to ask questions or open a PR in the repo when you're ready. Thanks!

Ayush-Kori commented 1 year ago

Hey can u tell how to run it on docker ??

stevejalim commented 1 year ago

Heya @Ayush-Kori https://bedrock.readthedocs.io/en/latest/install.html#pocket-mode (as linked to above) should help you run Bedrock in Pocket Mode, but it's basically make run-pocket

maureenlholland commented 1 year ago

Hi @Ayush-Kori, were you able to get Pocket up and running locally? If things have changed and you're too busy to work on this now, I can take over. Let me know, thanks!

maureenlholland commented 1 year ago

Hi @Ayush-Kori thanks again for your interest but I'm going to take over here to close the issue out