mozilla / bedrock

Making mozilla.org awesome, one pebble at a time
https://www.mozilla.org
Mozilla Public License 2.0
1.18k stars 919 forks source link

[GTM Review] Split product_download into product specific events #14108

Closed stephaniehobson closed 9 months ago

stephaniehobson commented 9 months ago

One-line summary

Review and publish "product_download events" workspace.

Significant changes and points to review

This change is to send both the existing event product_download and separate events for each product.

The supporting bedrock changes are in #14083 and published on demo9. The workspace and bedrock changes can go live in any order.

Issue / Bugzilla link

14072

Testing

14083 Is on demo9 for testing purposes.

At the top of the tag manager, click the G-YBFC8BJZW8 tag to see the hits sent. You can also watch the events coming in with the GA debugger (Admin > Property Settings > Data display > DebugView) on the www_mozilla_org - GA4 Testing property.

Both product_download and a product specific download event should fire.

alexgibson commented 9 months ago

I tested the changes above and everything looks to be as expected

I did notice there are not Pocket download events firing though - is there maybe something missing from your PR for Pocket?

stephaniehobson commented 9 months ago

The GTM side isn't missing anything, I'll check the PR.

stephaniehobson commented 9 months ago

The Pocket download links are missing the class they need, I'll file a separate issue.