search

mozilla / bedrock

Making mozilla.org awesome, one pebble at a time
https://www.mozilla.org
Mozilla Public License 2.0
1.17k stars 913 forks source link

[M24] New base bundle doesn't include rebrand logic for old footer #15206

Open janbrasna opened 1 day ago

janbrasna commented 1 day ago

Description

Even after switching to the 2024 base stylesheet, the old nav & footer is still being used (basically because it's an independent switch, but even that shows it only for default locale or progressively only to locales based on its ftl activation threshold / translation completion), so to avoid unexpected changes between various switch combinations being flipped, even the new base stylesheet should support both old and new brand based on its switch/class.

Steps to reproduce

With all refresh switches flipped, visit some non-en page, e.g. http://localhost:8000/cy/ or http://localhost:8000/sco/?xv=legacy — these will display the og elements that will continue to be served for parts of the site.

Expected result

New logo in both old nav & footer.

Actual result

Screenshot 2024-09-22 at 18 53 32

Header links proper img based on the switch. Footer only adds class based on the switch, so the declaration for .m24-logo needs to set the correct asset explicitly.

Environment

All the switches enabled.

alexgibson commented 23 hours ago

See also: https://github.com/mozilla/bedrock/issues/15120

janbrasna commented 23 hours ago

@alexgibson I think this was actually started with #15144 (base-protocol-2024.scss) — so this only follows up (monkey-patching the same temp overrides supporting the m24-logo switch in all the bundle variants:/…) — feel free to supersede it once there's a better fix.