search

mozilla / bedrock

Making mozilla.org awesome, one pebble at a time
https://www.mozilla.org
Mozilla Public License 2.0
1.18k stars 919 forks source link

update top margin for pages with sub nav fixes issue #15214 #15215

Closed wen-2018 closed 1 month ago

wen-2018 commented 1 month ago

One-line summary

This PR fixes the margin on mobile pages.

Significant changes and points to review

Issue / Bugzilla link

https://github.com/mozilla/bedrock/issues/15214

Testing

1.Set SWITCH_M24_NAVIGATION_AND_FOOTER to be true in your local env file

  1. Go to any page with a sub nav, such as http://localhost:8000/en-US/firefox/new/
  2. Resize browser to mobile screen size
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.88%. Comparing base (977dbf6) to head (e096479). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15215 +/- ## ======================================= Coverage 77.88% 77.88% ======================================= Files 163 163 Lines 8480 8480 ======================================= Hits 6605 6605 Misses 1875 1875 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.