Ensure we only use x-default on appropriate pages

stevejalim commented 2 days ago

One-line summary

This changeset reduces the number of pages containing a link with hreflang of x-default. This change will improve/reduce harm to our SEO

Significant changes and points to review

You can test-drive this code on https://www-demo8.allizom.org/ - though note that all canonical urls there will refer to www.mozilla.org not www-demo8.allizom.org

To check/confirm:

[ ] 1. hreflang="x-default" must be present in the source code of locale-specific homepages - https://www-demo8.allizom.org/en-US/, https://www-demo8.allizom.org/de/ etc
[ ] 2. hreflang="x-default" must be present on the locale-selection page for bots (Running curl https://www-demo8.allizom.org/ | grep x-default will show that link tag is present)
[ ] 3. hreflang="x-default" must not be on any other pages
[ ] 4. hreflang="x-default" has been removed from https://www-demo8.allizom.org/credits/faq/

Issue / Bugzilla link

Resolves #15464

stevejalim commented 2 days ago

@a-kyne this is ready to test - please see the description above

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.82%. Comparing base (02db980) to head (5c4802a). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #15526 +/- ## ========================================== + Coverage 78.78% 78.82% +0.03% ========================================== Files 157 158 +1 Lines 8257 8282 +25 ========================================== + Hits 6505 6528 +23 - Misses 1752 1754 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

mozilla / bedrock