search

mozilla / bedrock

Making mozilla.org awesome, one pebble at a time
https://www.mozilla.org
Mozilla Public License 2.0
1.16k stars 914 forks source link

Prefer win64 full installer on /installer-help/ when appropriate #8635

Open amychurchwell opened 4 years ago

amychurchwell commented 4 years ago

Description

(bug 1564333)

Currently, when an user lands on https://www.mozilla.org/firefox/installer-help/?channel=release, they always get a win32 full installer, even if the stub installer finds their Windows OS to be compatible with win64 builds of Firefox.

grininja commented 4 years ago

I want to work on this issue

ejregithub commented 4 years ago

This appears to have been corrected. @Errolyn just tested with their Win64 bit build machine and found that the proper, expected Win64 bit build was provided.

alexgibson commented 4 years ago

As far as I know this was never fixed on the bedrock side, so I’m very curious as to how the 64bit build is being provided?

ejregithub commented 4 years ago

And blah . . . this remains, obviously. Thank you for confirming @alexgibson. I tested on my wife's Win64 bit and was provided the 32bit version of Firefox.

alexgibson commented 1 year ago

Depends on https://bugzilla.mozilla.org/show_bug.cgi?id=1621749

alexgibson commented 2 months ago

Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1621749 has been fixed, so this is actually ready to work on I think!

The new installer_arch parameter should now provide the following hints to the /installer-help/ page:

  1. if installer_arch=1 we should serve Windows 32bit installer.
  2. If installer_arch=2 we should serve the Windows 64bit installer.
  3. If installer_arch=3 we should serve the Windows AARCH64 installer.

If the installer_arch parameter is not present (i.e. unknown), we can assume to show links to the Windows 32bit installer.