mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
246 stars 98 forks source link

Remove columns from view #5650

Closed kwindau closed 2 months ago

kwindau commented 2 months ago

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 2 months ago

Integration report for "Remove columns from view"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen_v2/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen_v2/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen_v2/view.sql 2024-05-23 15:51:04.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen_v2/view.sql 2024-05-23 15:51:03.000000000 +0000 @@ -23,26 +23,7 @@ mozfun.bits28.days_since_seen( days_visited_1_uri_private_mode_bits ) AS days_since_visited_1_uri_private_mode, - cls.* EXCEPT (app_name), - CASE - WHEN cls.isp_name = 'BrowserStack' - THEN CONCAT(cls.app_name, ' ', cls.isp_name) - WHEN distribution_id = 'MozillaOnline' - THEN CONCAT(cls.app_name, ' ', cls.distribution_id) - ELSE cls.app_name - END AS app_name, - IFNULL(mozfun.bits28.days_since_seen(cls.days_active_bits) = 0, FALSE) AS is_dau, - IFNULL(mozfun.bits28.days_since_seen(cls.days_active_bits) < 7, FALSE) AS is_wau, - IFNULL(mozfun.bits28.days_since_seen(cls.days_active_bits) < 28, FALSE) AS is_mau, - IFNULL(mozfun.bits28.days_since_seen(cls.days_seen_bits) = 0, FALSE) AS is_daily_user, - IFNULL(mozfun.bits28.days_since_seen(cls.days_seen_bits) < 7, FALSE) AS is_weekly_user, - IFNULL(mozfun.bits28.days_since_seen(cls.days_seen_bits) < 28, FALSE) AS is_monthly_user, - IF( - LOWER(IFNULL(cls.isp_name, '')) <> "browserstack" - AND LOWER(IFNULL(cls.distribution_id, '')) <> "mozillaonline", - TRUE, - FALSE - ) AS is_desktop + cls.* FROM `moz-fx-data-shared-prod.telemetry_derived.clients_last_seen_v2` cls ) ```

Link to full diff