mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
253 stars 100 forks source link

[RS-1246] Fix DDG DAU in search_revenue_levers_daily #5655

Closed skahmann3 closed 4 months ago

skahmann3 commented 4 months ago

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 4 months ago

Integration report for "Fix search_revenue_levers_daily"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql 2024-05-24 00:26:52.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql 2024-05-24 00:26:46.000000000 +0000 @@ -90,8 +90,8 @@ COUNT( DISTINCT IF( ( - default_search_engine LIKE('%ddg%') - OR default_search_engine LIKE('%duckduckgo%') + (default_search_engine LIKE('%ddg%') + OR default_search_engine LIKE('%duckduckgo%')) AND NOT default_search_engine LIKE('%addon%') ), client_id, @@ -103,8 +103,8 @@ (engine) IN ('ddg', 'duckduckgo') AND sap > 0 AND ( - default_search_engine LIKE('%ddg%') - OR default_search_engine LIKE('%duckduckgo%') + (default_search_engine LIKE('%ddg%') + OR default_search_engine LIKE('%duckduckgo%')) AND NOT default_search_engine LIKE('%addon%') ), client_id, ```

Link to full diff

dataops-ci-bot commented 4 months ago

Integration report for "Query formatting"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql 2024-05-24 13:21:14.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql 2024-05-24 13:21:20.000000000 +0000 @@ -90,8 +90,7 @@ COUNT( DISTINCT IF( ( - default_search_engine LIKE('%ddg%') - OR default_search_engine LIKE('%duckduckgo%') + (default_search_engine LIKE('%ddg%') OR default_search_engine LIKE('%duckduckgo%')) AND NOT default_search_engine LIKE('%addon%') ), client_id, @@ -103,8 +102,7 @@ (engine) IN ('ddg', 'duckduckgo') AND sap > 0 AND ( - default_search_engine LIKE('%ddg%') - OR default_search_engine LIKE('%duckduckgo%') + (default_search_engine LIKE('%ddg%') OR default_search_engine LIKE('%duckduckgo%')) AND NOT default_search_engine LIKE('%addon%') ), client_id, ```

Link to full diff

alekhyamoz commented 4 months ago

@skahmann3 how far back do we need to backfill this table?

dataops-ci-bot commented 4 months ago

Integration report for "Merge branch 'main' into RS-1246-fix-DDG-DAU-in-levers-daily"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql 2024-05-24 16:37:47.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/query.sql 2024-05-24 16:37:42.000000000 +0000 @@ -90,8 +90,7 @@ COUNT( DISTINCT IF( ( - default_search_engine LIKE('%ddg%') - OR default_search_engine LIKE('%duckduckgo%') + (default_search_engine LIKE('%ddg%') OR default_search_engine LIKE('%duckduckgo%')) AND NOT default_search_engine LIKE('%addon%') ), client_id, @@ -103,8 +102,7 @@ (engine) IN ('ddg', 'duckduckgo') AND sap > 0 AND ( - default_search_engine LIKE('%ddg%') - OR default_search_engine LIKE('%duckduckgo%') + (default_search_engine LIKE('%ddg%') OR default_search_engine LIKE('%duckduckgo%')) AND NOT default_search_engine LIKE('%addon%') ), client_id, ```

Link to full diff