mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
246 stars 98 forks source link

Add more null channels for metrics_clients_last_seen test #5662

Closed scholtzan closed 2 months ago

scholtzan commented 2 months ago

Some more error data for evaluating the observability tools

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 2 months ago

Integration report for "Add more null channels for metrics_clients_last_seen test"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/data-observability-dev/fenix_derived/metrics_clients_last_seen_v1/query.sql /tmp/workspace/generated-sql/sql/data-observability-dev/fenix_derived/metrics_clients_last_seen_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/data-observability-dev/fenix_derived/metrics_clients_last_seen_v1/query.sql 2024-05-27 17:24:24.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/data-observability-dev/fenix_derived/metrics_clients_last_seen_v1/query.sql 2024-05-27 17:24:23.000000000 +0000 @@ -15,13 +15,12 @@ AND submission_date = "2024-05-23" AND sample_id < 50 UNION ALL --- create an entry where normalized channel is null +-- create entries where normalized channel is null SELECT * REPLACE (NULL AS normalized_channel), FROM `moz-fx-data-shared-prod.fenix_derived.metrics_clients_last_seen_v1` WHERE submission_date = @submission_date - AND submission_date = "2024-05-24" -LIMIT - 1 + AND submission_date = "2024-05-27" + AND sample_id = 0 ```

Link to full diff