mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
246 stars 98 forks source link

Normalizing campaign names #5681

Closed soGaussian closed 1 month ago

soGaussian commented 1 month ago

Converted all the campaign names to upper case to prevent us from seeing situations like eu and EU in our segments

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 1 month ago

Integration report for "Normalizing campaign names"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql 2024-05-30 14:02:33.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql 2024-05-30 14:02:39.000000000 +0000 @@ -78,9 +78,12 @@ SELECT date, campaigns_v2.campaign_name AS campaign, - mozfun.map.get_key(campaigns_v2.campaign_segments, "region") AS campaign_region, - mozfun.map.get_key(campaigns_v2.campaign_segments, "country_code") AS campaign_country_code, - mozfun.map.get_key(campaigns_v2.campaign_segments, "language") AS campaign_language, + mozfun.map.get_key(UPPER(campaigns_v2.campaign_segments), "region") AS campaign_region, + mozfun.map.get_key( + UPPER(campaigns_v2.campaign_segments), + "country_code" + ) AS campaign_country_code, + mozfun.map.get_key(UPPER(campaigns_v2.campaign_segments), "language") AS campaign_language, campaigns_v2.campaign_segments, ad_groups_v1.ad_group_name AS ad_group, ad_groups_v1.ad_group_segments, ```

Link to full diff

dataops-ci-bot commented 1 month ago

Integration report for "Fixed the placement of the UPPER function"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql 2024-05-30 14:17:51.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/query.sql 2024-05-30 14:17:51.000000000 +0000 @@ -78,9 +78,11 @@ SELECT date, campaigns_v2.campaign_name AS campaign, - mozfun.map.get_key(campaigns_v2.campaign_segments, "region") AS campaign_region, - mozfun.map.get_key(campaigns_v2.campaign_segments, "country_code") AS campaign_country_code, - mozfun.map.get_key(campaigns_v2.campaign_segments, "language") AS campaign_language, + UPPER(mozfun.map.get_key(campaigns_v2.campaign_segments, "region")) AS campaign_region, + UPPER( + mozfun.map.get_key(campaigns_v2.campaign_segments, "country_code") + ) AS campaign_country_code, + UPPER(mozfun.map.get_key(campaigns_v2.campaign_segments, "language")) AS campaign_language, campaigns_v2.campaign_segments, ad_groups_v1.ad_group_name AS ad_group, ad_groups_v1.ad_group_segments, ```

Link to full diff