kik-kik commented 1 month ago

feat: update firefox_android_clients_v1 to pull distribution_id only from the baseline ping

The distribution_id currently appears to be wrong inside firefox_android_clients_v1, this is a quick "solution" to try and mitigate this issue by pulling distribution_id from the baseline ping instead. The reason for this is that we decided that the baseline ping on mobile will serve as the primary source of truth in relation to KPI reporting.

Checklist for reviewer:

[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
[ ] If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
[ ] If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
[ ] When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

[ ] Follow the change control procedure

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 1 month ago

Integration report for "feat: update firefox_android_clients_v1 to pull distribution_id only from the baseline ping"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:03:38.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:03:25.000000000 +0000 @@ -19,6 +19,7 @@ app_display_version AS app_version, locale, is_new_profile, + distribution_id, FROM `moz-fx-data-shared-prod.fenix.baseline_clients_daily` WHERE @@ -43,7 +44,8 @@ device_model, os_version, app_version, - locale + locale, + distribution_id, FROM baseline_clients WHERE @@ -154,11 +156,6 @@ ORDER BY submission_timestamp ASC )[SAFE_OFFSET(0)] AS play_store_attribution_install_referrer_response, - ARRAY_AGG( - metrics.string.first_session_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, ARRAY_AGG(metrics.string.meta_attribution_app IGNORE NULLS ORDER BY submission_timestamp ASC)[ SAFE_OFFSET(0) ] AS meta_attribution_app, @@ -231,11 +228,6 @@ ORDER BY submission_timestamp DESC )[SAFE_OFFSET(0)] AS last_reported_adjust_campaign, - ARRAY_AGG( - metrics.string.metrics_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, FROM fenix.metrics AS fenix_metrics WHERE @@ -299,7 +291,7 @@ first_session.play_store_attribution_source, first_session.play_store_attribution_term, first_session.play_store_attribution_install_referrer_response, - COALESCE(first_session.distribution_id, metrics.distribution_id) AS distribution_id, + baseline.distribution_id, first_session.meta_attribution_app AS meta_attribution_app, metrics.last_reported_adjust_campaign AS last_reported_adjust_campaign, metrics.last_reported_adjust_ad_group AS last_reported_adjust_ad_group, ```

Link to full diff

dataops-ci-bot commented 1 month ago

Integration report for "feat: update firefox_android_clients_v1 baseline test schema to include distribution_id"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:08:03.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:08:02.000000000 +0000 @@ -19,6 +19,7 @@ app_display_version AS app_version, locale, is_new_profile, + distribution_id, FROM `moz-fx-data-shared-prod.fenix.baseline_clients_daily` WHERE @@ -43,7 +44,8 @@ device_model, os_version, app_version, - locale + locale, + distribution_id, FROM baseline_clients WHERE @@ -154,11 +156,6 @@ ORDER BY submission_timestamp ASC )[SAFE_OFFSET(0)] AS play_store_attribution_install_referrer_response, - ARRAY_AGG( - metrics.string.first_session_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, ARRAY_AGG(metrics.string.meta_attribution_app IGNORE NULLS ORDER BY submission_timestamp ASC)[ SAFE_OFFSET(0) ] AS meta_attribution_app, @@ -231,11 +228,6 @@ ORDER BY submission_timestamp DESC )[SAFE_OFFSET(0)] AS last_reported_adjust_campaign, - ARRAY_AGG( - metrics.string.metrics_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, FROM fenix.metrics AS fenix_metrics WHERE @@ -299,7 +291,7 @@ first_session.play_store_attribution_source, first_session.play_store_attribution_term, first_session.play_store_attribution_install_referrer_response, - COALESCE(first_session.distribution_id, metrics.distribution_id) AS distribution_id, + baseline.distribution_id, first_session.meta_attribution_app AS meta_attribution_app, metrics.last_reported_adjust_campaign AS last_reported_adjust_campaign, metrics.last_reported_adjust_ad_group AS last_reported_adjust_ad_group, ```

Link to full diff

dataops-ci-bot commented 1 month ago

Integration report for "fix: resolve distribution_id not in baseline error"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:26:37.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:26:30.000000000 +0000 @@ -19,6 +19,7 @@ app_display_version AS app_version, locale, is_new_profile, + distribution_id, FROM `moz-fx-data-shared-prod.fenix.baseline_clients_daily` WHERE @@ -43,7 +44,7 @@ device_model, os_version, app_version, - locale + locale, FROM baseline_clients WHERE @@ -154,11 +155,6 @@ ORDER BY submission_timestamp ASC )[SAFE_OFFSET(0)] AS play_store_attribution_install_referrer_response, - ARRAY_AGG( - metrics.string.first_session_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, ARRAY_AGG(metrics.string.meta_attribution_app IGNORE NULLS ORDER BY submission_timestamp ASC)[ SAFE_OFFSET(0) ] AS meta_attribution_app, @@ -231,11 +227,6 @@ ORDER BY submission_timestamp DESC )[SAFE_OFFSET(0)] AS last_reported_adjust_campaign, - ARRAY_AGG( - metrics.string.metrics_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, FROM fenix.metrics AS fenix_metrics WHERE @@ -267,6 +258,9 @@ ARRAY_AGG(locale IGNORE NULLS ORDER BY submission_date DESC)[ SAFE_OFFSET(0) ] AS last_reported_locale, + ARRAY_AGG(distribution_id IGNORE NULLS ORDER BY submission_date DESC)[ + SAFE_OFFSET(0) + ] AS distribution_id, FROM baseline_clients GROUP BY @@ -299,7 +293,7 @@ first_session.play_store_attribution_source, first_session.play_store_attribution_term, first_session.play_store_attribution_install_referrer_response, - COALESCE(first_session.distribution_id, metrics.distribution_id) AS distribution_id, + baseline.distribution_id, first_session.meta_attribution_app AS meta_attribution_app, metrics.last_reported_adjust_campaign AS last_reported_adjust_campaign, metrics.last_reported_adjust_ad_group AS last_reported_adjust_ad_group, diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql 2024-05-30 17:26:37.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql 2024-05-30 17:26:30.000000000 +0000 @@ -43,7 +43,6 @@ scalar_parent_browser_engagement_total_uri_count_normal_and_private_mode_sum, scalar_parent_browser_engagement_total_uri_count_sum, is_default_browser, - isp_name, distribution_id, active_hours_sum, attribution.source AS attribution_source, ```

Link to full diff

dataops-ci-bot commented 1 month ago

Integration report for "Merge branch 'main' into feat/update-firefox_android_clients-to-pull-distribution-from-baseline"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:29:48.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql 2024-05-30 17:29:41.000000000 +0000 @@ -19,6 +19,7 @@ app_display_version AS app_version, locale, is_new_profile, + distribution_id, FROM `moz-fx-data-shared-prod.fenix.baseline_clients_daily` WHERE @@ -43,7 +44,7 @@ device_model, os_version, app_version, - locale + locale, FROM baseline_clients WHERE @@ -154,11 +155,6 @@ ORDER BY submission_timestamp ASC )[SAFE_OFFSET(0)] AS play_store_attribution_install_referrer_response, - ARRAY_AGG( - metrics.string.first_session_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, ARRAY_AGG(metrics.string.meta_attribution_app IGNORE NULLS ORDER BY submission_timestamp ASC)[ SAFE_OFFSET(0) ] AS meta_attribution_app, @@ -231,11 +227,6 @@ ORDER BY submission_timestamp DESC )[SAFE_OFFSET(0)] AS last_reported_adjust_campaign, - ARRAY_AGG( - metrics.string.metrics_distribution_id IGNORE NULLS - ORDER BY - submission_timestamp ASC - )[SAFE_OFFSET(0)] AS distribution_id, FROM fenix.metrics AS fenix_metrics WHERE @@ -267,6 +258,9 @@ ARRAY_AGG(locale IGNORE NULLS ORDER BY submission_date DESC)[ SAFE_OFFSET(0) ] AS last_reported_locale, + ARRAY_AGG(distribution_id IGNORE NULLS ORDER BY submission_date DESC)[ + SAFE_OFFSET(0) + ] AS distribution_id, FROM baseline_clients GROUP BY @@ -299,7 +293,7 @@ first_session.play_store_attribution_source, first_session.play_store_attribution_term, first_session.play_store_attribution_install_referrer_response, - COALESCE(first_session.distribution_id, metrics.distribution_id) AS distribution_id, + baseline.distribution_id, first_session.meta_attribution_app AS meta_attribution_app, metrics.last_reported_adjust_campaign AS last_reported_adjust_campaign, metrics.last_reported_adjust_ad_group AS last_reported_adjust_ad_group, ```

Link to full diff

mozilla / bigquery-etl