mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
244 stars 98 forks source link

fix: update entry date to be the same as the end_date #5699

Closed kik-kik closed 1 month ago

kik-kik commented 1 month ago

fix: update entry date to be the same as the end_date

This should address the following CI error:

    backfill = cls(
               ^^^^
  File "<attrs generated init bigquery_etl.backfill.parse.Backfill>", line 13, in __init__
  File "/root/project/bigquery_etl/backfill/parse.py", line 112, in validate_end_date
    raise ValueError(f"Invalid end date: {value}.")
ValueError: Invalid end date: 2024-05-31.

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 1 month ago

Integration report for "fix: update entry date to be the same as the end_date"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/retention_v1/backfill.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/retention_v1/backfill.yaml --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/retention_v1/backfill.yaml 2024-05-31 14:07:34.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/retention_v1/backfill.yaml 2024-05-31 14:07:41.000000000 +0000 @@ -1,4 +1,4 @@ -2024-05-30: +2024-05-31: start_date: 2021-01-01 end_date: 2024-05-31 reason: The table is created, this is to populate it with data. diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/retention_v1/backfill.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/retention_v1/backfill.yaml --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/retention_v1/backfill.yaml 2024-05-31 14:07:34.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/retention_v1/backfill.yaml 2024-05-31 14:07:41.000000000 +0000 @@ -1,4 +1,4 @@ -2024-05-30: +2024-05-31: start_date: 2021-01-01 end_date: 2024-05-31 reason: The table is created, this is to populate it with data. ```

Link to full diff