mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
244 stars 98 forks source link

The app_name is Firefox Desktop in all cases. #5720

Closed lucia-vargas-a closed 1 month ago

lucia-vargas-a commented 1 month ago

All the data in telemetry.desktop_active_users corresponds to Firefox Desktop. Normalizing it here for all downstream aggregates & analysis.

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 1 month ago

Integration report for "The app_name is Firefox Desktop in all cases."

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql 2024-06-03 20:02:46.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql 2024-06-03 20:02:46.000000000 +0000 @@ -26,10 +26,10 @@ days_active_bits, CASE WHEN isp_name = 'BrowserStack' - THEN CONCAT(app_name, ' ', isp_name) + THEN CONCAT('Firefox Desktop', ' ', isp_name) WHEN distribution_id = 'MozillaOnline' - THEN CONCAT(app_name, ' ', distribution_id) - ELSE app_name + THEN CONCAT('Firefox Desktop', ' ', distribution_id) + ELSE 'Firefox Desktop' END AS app_name, app_version, normalized_channel, ```

Link to full diff

dataops-ci-bot commented 1 month ago

Integration report for "Merge branch 'main' into DENG-3543_normalize_app_name"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql 2024-06-03 20:51:29.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/desktop_active_users/view.sql 2024-06-03 20:51:30.000000000 +0000 @@ -26,10 +26,10 @@ days_active_bits, CASE WHEN isp_name = 'BrowserStack' - THEN CONCAT(app_name, ' ', isp_name) + THEN CONCAT('Firefox Desktop', ' ', isp_name) WHEN distribution_id = 'MozillaOnline' - THEN CONCAT(app_name, ' ', distribution_id) - ELSE app_name + THEN CONCAT('Firefox Desktop', ' ', distribution_id) + ELSE 'Firefox Desktop' END AS app_name, app_version, normalized_channel, ```

Link to full diff