[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
[ ] If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
[ ] If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
[ ] When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.
For modifications to schemas in restricted namespaces (see CODEOWNERS):
Integration report for "Requires a filter on submission date in clients last seen raw"
sql.diff
Click to expand!
```diff
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql 2024-06-06 16:27:40.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql 2024-06-06 16:27:46.000000000 +0000
@@ -44,10 +44,12 @@
JOIN
clients_first_seen_14_days_ago clients
ON cls.client_id = clients.client_id
- AND cls.submission_date
+ WHERE
+ cls.submission_date
-- join the clients_last_seen so that we get the first 7 days of each client's main ping records (for the clients that sent > 0 main pings in their first week)
BETWEEN clients.first_main_ping_date
AND DATE_ADD(clients.first_main_ping_date, INTERVAL 6 DAY)
+ AND cls.submission_date >= '2023-11-01'
),
--STEP 2: For every client, get the first 7 days worth of main pings sent after their first main ping
client_activity_first_7_days AS (
```
Integration report for "Update where clause filter"
sql.diff
Click to expand!
```diff
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql 2024-06-06 16:39:06.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql 2024-06-06 16:39:06.000000000 +0000
@@ -44,10 +44,12 @@
JOIN
clients_first_seen_14_days_ago clients
ON cls.client_id = clients.client_id
- AND cls.submission_date
+ WHERE
+ cls.submission_date
-- join the clients_last_seen so that we get the first 7 days of each client's main ping records (for the clients that sent > 0 main pings in their first week)
BETWEEN clients.first_main_ping_date
AND DATE_ADD(clients.first_main_ping_date, INTERVAL 6 DAY)
+ AND cls.submission_date >= DATE_SUB(report_date, INTERVAL 1 DAY)
),
--STEP 2: For every client, get the first 7 days worth of main pings sent after their first main ping
client_activity_first_7_days AS (
```
Click to expand!
```diff
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql 2024-06-06 16:54:47.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/conversion_event_categorization_v1/query.sql 2024-06-06 16:54:46.000000000 +0000
@@ -44,10 +44,12 @@
JOIN
clients_first_seen_14_days_ago clients
ON cls.client_id = clients.client_id
- AND cls.submission_date
+ WHERE
+ cls.submission_date
-- join the clients_last_seen so that we get the first 7 days of each client's main ping records (for the clients that sent > 0 main pings in their first week)
BETWEEN clients.first_main_ping_date
AND DATE_ADD(clients.first_main_ping_date, INTERVAL 6 DAY)
+ AND cls.submission_date >= DATE_SUB(@report_date, INTERVAL 1 DAY)
),
--STEP 2: For every client, get the first 7 days worth of main pings sent after their first main ping
client_activity_first_7_days AS (
```
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show up in the logs of themanual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task