Closed BenWu closed 2 weeks ago
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
I filed https://github.com/mozilla/bigquery-etl/issues/5804 to track deployed materialized views not getting updated. If I'm looking at it correctly, merging this shouldn't actually change any of the deployed views until that's fixed.
I also just sorted the events lists that get passed into the templates so the diffs should be more stable
fixes #5797
This recreates the materialized views that were removed from the generated sql in https://github.com/mozilla/bigquery-etl/pull/5576. Looking at the generated sql diff,
monitoring/event_monitoring_live/view.sql
wasn't changed so I think that means the nothing new gets added or removed as expected (other thangleanjs_docs_derived.event_monitoring_live_v1
).@scholtzan One thing I'm not sure about is that this adds
events_v1
to the union in some of the materialized views. Did we intentionally want to exclude those from the views for apps not listed in the bqetl config?Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show up in the logs of themanual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task