mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
241 stars 98 forks source link

GROWTH-143 add 3 new conversion events #5810

Closed kwindau closed 1 week ago

kwindau commented 1 week ago

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 1 week ago

Integration report for "GROWTH-143 add 3 new conversion events"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/query.sql 2024-06-19 20:18:35.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/query.sql 2024-06-19 20:18:51.000000000 +0000 @@ -15,6 +15,12 @@ THEN "firefox_first_ad_click" WHEN "did_returned_second_day" THEN "firefox_second_run" + WHEN "first_wk_5_actv_days_and_1_or_more_search_w_ads" + THEN "first_wk_5_actv_days_and_1_or_more_search_w_ads" + WHEN "first_wk_3_actv_days_and_1_or_more_search_w_ads" + THEN "first_wk_3_actv_days_and_1_or_more_search_w_ads" + WHEN "first_wk_3_actv_days_and_24_active_minutes" + THEN "first_wk_3_actv_days_and_24_active_minutes" ELSE NULL END AS conversion_name, FROM @@ -23,7 +29,10 @@ did_firefox_first_run, did_search, did_click_ad, - did_returned_second_day + did_returned_second_day, + first_wk_5_actv_days_and_1_or_more_search_w_ads, + first_wk_3_actv_days_and_1_or_more_search_w_ads, + first_wk_3_actv_days_and_24_active_minutes ) ) WHERE ```

Link to full diff