KPI reviewers need to be aware that CODEOWNERS needs to be updated in the event paths related to sql generation for KPIs are moved.
CI failures are due to a Dockerhub outage.
Checklist for reviewer:
[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
[ ] If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
[ ] If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
[ ] When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.
For modifications to schemas in restricted namespaces (see CODEOWNERS):
lucia-vargas-a
commented
1 week ago
When https://github.com/mozilla/bigquery-etl/pull/5008/ landed it renamed some files that were subject to KPI change control, and the new paths were not annotated as subject to change control. Therefore https://github.com/mozilla/bigquery-etl/pull/5808/ was not subject to change control and apparently caused a KPI outage.
KPI reviewers need to be aware that CODEOWNERS needs to be updated in the event paths related to sql generation for KPIs are moved.
CI failures are due to a Dockerhub outage.
Checklist for reviewer:
<username>:<branch>of the fork as parameter. The parameter will also show up in the logs of themanual-trigger-required-for-forkCI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS):┆Issue is synchronized with this Jira Task