mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
241 stars 98 forks source link

fix friendly name. This is Conversions, not acquisitions #5828

Closed Marlene-M-Hirose closed 1 week ago

Marlene-M-Hirose commented 1 week ago

In reviewing files, I realized that the friendly name was App Acquisitions when this is clearly App Conversions

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 1 week ago

Integration report for "fix friendly name. This is Conversions, not acquisitions"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/microsoft_derived/app_conversions_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/microsoft_derived/app_conversions_v1/metadata.yaml --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/microsoft_derived/app_conversions_v1/metadata.yaml 2024-06-24 15:43:02.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/microsoft_derived/app_conversions_v1/metadata.yaml 2024-06-24 15:43:26.000000000 +0000 @@ -1,4 +1,4 @@ -friendly_name: App Acquisitions +friendly_name: App Conversions description: |- This table represents acquisition data downloaded from the Microsoft Store for Firefox, FX Beta and FX Nightly The link for this data is here: https://manage.devcenter.microsoft.com/v1.0/my/analytics/appchannelconversions? ```

Link to full diff