When we implemented retention metadata support via default_table_workgroup_access, we introduced a gotcha where unless you specify the value of default_table_workgroup_access explicitly in a table's manually created workgroup_access, access to that table will be restricted to just the manual grants if there are deprecated tables in the same dataset.
We should for non-deprecated tables automatically apply default_table_workgroup_access to the table-level metadata.yaml workgroup_access, and probably have a CI/lint check to warn against the redundant specification in both places once this is implemented.
When we implemented retention metadata support via
default_table_workgroup_access, we introduced a gotcha where unless you specify the value ofdefault_table_workgroup_accessexplicitly in a table's manually createdworkgroup_access, access to that table will be restricted to just the manual grants if there are deprecated tables in the same dataset.https://github.com/mozilla/bigquery-etl/commit/80dc78673f60c2f4d5141d797ff84ec1875298f2 is an example of this: if there were deprecations in
mozilla_org_derived, give the way our metadata generation currently works,workgroup:mozilla-confidentialwould have lost access to the table.We should for non-deprecated tables automatically apply
default_table_workgroup_accessto the table-level metadata.yamlworkgroup_access, and probably have a CI/lint check to warn against the redundant specification in both places once this is implemented.┆Issue is synchronized with this Jira Task