Open data-sync-user opened 3 days ago
➤ Misun Mizener commented:
Assigning to Alexander Nicholson as I understand you helped with the current country mapping dataset. Tagging George Kaberere for context (as this came up during the Beyond DAU sprint discussions).
➤ Sean Rose commented:
I have thoughts/concerns:
➤ Alexander Nicholson commented:
{quote}Certain 'country or region' names in the Legal-recommended (see the Wiki link above) GENC list ( https://nsgreg.nga.mil/registries/browse/results.jsp?registryType=genc®isterField=GEC&itemTypeField=fgp&entryTypeField=all ) are different from the country names currently in the data source such as:
I’ll do this in a PR shortly
{quote}* The field name ‘Region’ should be switched to ‘Continent’ (to capture values like Asia, North America, Antarctica, etc.){quote}
Looking into this currently. It seems since https://github.com/mozilla/bigquery-etl/pull/5562 ( https://github.com/mozilla/bigquery-etl/pull/5562|smart-link ) , all the non-continent regions have been removed, so continent might be more accurate also. This will require some coordinated changes.
{quote}* The field name ‘Country’ should be switched to ‘Country or Region’{quote}
This one is more complicated. Echoing some of Sean’s comments below, a few quick questions Misun Mizener:
In alignment with the guidance stated in this Wiki, please consolidate the field names and values for the country/region names we are using.
Requirements to consider
Context
When we rolled out the new version of the KPI dashboard which now has regional breakdowns of DAU, a Mozillian requested changing ‘Taiwan, province of China’ to ‘Taiwan’. [~accountid:6345617db391eab61f71c0a2] consulted Legal who pointed the team to the Wiki page and suggested we implement the changes outlined above.
┆Issue is synchronized with this Jira Story