bug 1904841: fix sql udf cast_json breaking w string keys

[edugfilho]

fixes 1904841 Checklist for reviewer:

• [ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
• [ ] If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
• [ ] If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
• [ ] When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

• [ ] Follow the change control procedure

┆Issue is synchronized with this Jira Task

[dataops-ci-bot]

Integration report for "fix sql udf cast_json breaking w string keys"

sql.diff

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql /tmp/workspace/generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql --- /tmp/workspace/main-generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql 2024-06-26 13:34:10.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql 2024-06-26 13:34:05.000000000 +0000 @@ -16,7 +16,12 @@ COALESCE( CONCAT( '{', - STRING_AGG(CONCAT('"', key, '":', ROUND(value, 4)) ORDER BY CAST(key AS FLOAT64)), + STRING_AGG( + CONCAT('"', key, '":', ROUND(value, 4)) + ORDER BY + COALESCE(SAFE_CAST(key AS FLOAT64)), + key + ), '}' ), "{}" @@ -45,3 +50,9 @@ ) ), assert.equals('{}', glam.histogram_cast_json(ARRAY>[])), + assert.equals( + '{"always":0.5,"never":0.5}', + glam.histogram_cast_json( + ARRAY>[("always", 0.5), ("never", 0.5)] + ) + ), ```

Link to full diff

[dataops-ci-bot]

Integration report for "Merge branch 'main' into fix-udf-cast-json-string"

sql.diff

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql /tmp/workspace/generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql --- /tmp/workspace/main-generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql 2024-06-26 17:28:42.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/mozfun/glam/histogram_cast_json/udf.sql 2024-06-26 17:28:53.000000000 +0000 @@ -16,7 +16,12 @@ COALESCE( CONCAT( '{', - STRING_AGG(CONCAT('"', key, '":', ROUND(value, 4)) ORDER BY CAST(key AS FLOAT64)), + STRING_AGG( + CONCAT('"', key, '":', ROUND(value, 4)) + ORDER BY + COALESCE(SAFE_CAST(key AS FLOAT64)), + key + ), '}' ), "{}" @@ -45,3 +50,9 @@ ) ), assert.equals('{}', glam.histogram_cast_json(ARRAY>[])), + assert.equals( + '{"always":0.5,"never":0.5}', + glam.histogram_cast_json( + ARRAY>[("always", 0.5), ("never", 0.5)] + ) + ), ```

Link to full diff