Add normalized_app_name_os to mobile search aggregate table

alekhyamoz commented 4 days ago

Checklist for reviewer:

[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
[ ] If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
[ ] If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
[ ] When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

[ ] Follow the change control procedure

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 4 days ago

Integration report for "Add normalized_app_name_os to mobile search aggregate table"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-26 20:39:57.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-26 20:40:12.000000000 +0000 @@ -23,6 +23,7 @@ SUM(search_with_ads_organic) AS search_with_ads_organic, SUM(unknown) AS unknown, CAST(NULL AS string) normalized_engine, + `mozfun.mobile_search.normalize_app_name`(app_name, os).normalized_app_name_os FROM mobile_search_clients_daily_v1 WHERE ```

Link to full diff

dataops-ci-bot commented 4 days ago

Integration report for "Fix CI"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-26 21:00:08.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-26 20:59:52.000000000 +0000 @@ -23,6 +23,7 @@ SUM(search_with_ads_organic) AS search_with_ads_organic, SUM(unknown) AS unknown, CAST(NULL AS string) normalized_engine, + `mozfun.mobile_search.normalize_app_name`(app_name, os) AS normalized_app_name_os FROM mobile_search_clients_daily_v1 WHERE diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-26 21:00:08.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-26 20:59:52.000000000 +0000 @@ -71,3 +71,6 @@ - mode: NULLABLE name: ad_click_organic type: INTEGER +- mode: NULLABLE + name: normalized_app_name_os + type: STRING ```

Link to full diff

dataops-ci-bot commented 4 days ago

Integration report for "Merge branch 'main' into add_norm_app_os_aggs"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-27 12:03:18.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-27 12:03:18.000000000 +0000 @@ -23,6 +23,10 @@ SUM(search_with_ads_organic) AS search_with_ads_organic, SUM(unknown) AS unknown, CAST(NULL AS string) normalized_engine, + `mozfun.mobile_search.normalize_app_name`( + app_name, + os + ).normalized_app_name_os AS normalized_app_name_os FROM mobile_search_clients_daily_v1 WHERE diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-27 12:03:18.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-27 12:03:18.000000000 +0000 @@ -71,3 +71,6 @@ - mode: NULLABLE name: ad_click_organic type: INTEGER +- mode: NULLABLE + name: normalized_app_name_os + type: STRING ```

Link to full diff

dataops-ci-bot commented 4 days ago

Integration report for "Merge branch 'main' into add_norm_app_os_aggs"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-27 12:23:49.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-27 12:24:02.000000000 +0000 @@ -23,6 +23,10 @@ SUM(search_with_ads_organic) AS search_with_ads_organic, SUM(unknown) AS unknown, CAST(NULL AS string) normalized_engine, + `mozfun.mobile_search.normalize_app_name`( + app_name, + os + ).normalized_app_name_os AS normalized_app_name_os FROM mobile_search_clients_daily_v1 WHERE diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-27 12:23:49.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-27 12:24:02.000000000 +0000 @@ -71,3 +71,6 @@ - mode: NULLABLE name: ad_click_organic type: INTEGER +- mode: NULLABLE + name: normalized_app_name_os + type: STRING ```

Link to full diff

dataops-ci-bot commented 4 days ago

Integration report for "Merge branch 'main' into add_norm_app_os_aggs"

`sql.diff`

Click to expand!

```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-27 14:34:06.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/query.sql 2024-06-27 14:34:05.000000000 +0000 @@ -23,6 +23,10 @@ SUM(search_with_ads_organic) AS search_with_ads_organic, SUM(unknown) AS unknown, CAST(NULL AS string) normalized_engine, + `mozfun.mobile_search.normalize_app_name`( + app_name, + os + ).normalized_app_name_os AS normalized_app_name_os FROM mobile_search_clients_daily_v1 WHERE diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-27 14:34:06.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/search_derived/mobile_search_aggregates_v1/schema.yaml 2024-06-27 14:34:05.000000000 +0000 @@ -71,3 +71,6 @@ - mode: NULLABLE name: ad_click_organic type: INTEGER +- mode: NULLABLE + name: normalized_app_name_os + type: STRING ```

Link to full diff

mozilla / bigquery-etl